app locale variable issue fixed in Translation Driver #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have faced out an issue on translation driver about your $sourceLanguage property, this variable has set on binding Translation::class, so when app::locale variable changes, $sourceLanguage keeps same. Thus, I propose that you can use one of app()->getLocale() or App::getLocale(), because I change this app locale variable on a middleware. Your translation view (translation/languages/translations/index.blade.php) occurs an error because of changing app->locale. At now, sourceLanguage property has assigned in vain. You can remove this assignments after checking it out.